replace deprecated grid_scores_ attribute
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mdb571! We are in the middle of some PR triage and review right now, and will take a look at this soon. In the meantime, can you fix these lint errors? Looks like a couple of line lengths are just a bit too long. Thanks! |
|
Irrelevant for now, should be implemented during bumping |
|
Thanks @valentynbez! We will either include skbio 1.2 in a patch release within the next couple of weeks, or we will hold off until our next release (~Feb 2023) to include it, pending any reverse dependency issues we may run into. We will make an announcement on the forum with details once we have things worked out on our end! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid_scores_attribute is deprecated and will be removed in sklearn 1.2 .This PR proposes to use the preferred
cv_results_in favour