openlayers: max-height of popup-content #1060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed max-height of popup-content to 90vh viewport-width (vw) is used in multiple places where vh would be more appropriate. More fixes are needed. max-width changed to 70vw, this allows for easy closing of the popup in my test
|
I opened an issue for the other instances of vw vs. vh: |
|
Thank you for your contribution, I will make some changes manually as I don't agree with the size of 90. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed max-height of popup-content to 90vh
viewport-width (vw) is used in multiple places where vh would be more appropriate. More fixes are needed.
max-width changed to 70vw, this allows for easy closing of the popup in my test