-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow doing windows builds with qt5/6 and osgeo4w dependencies #57445
base: master
Are you sure you want to change the base?
Conversation
jef-n
commented
May 15, 2024
- remove unused osgeo4w and NSIS packaging files and disabled azure-pipeline build
- integrate osgeo4w patches currently used for qgis-qt6-dev (superceeds changes to support msvc builds with qt6 #56980)
- also adds pr comments to artifacts and dashboard test results
- name: 'Post artifact download link and test results as comment on PR' | ||
uses: actions/github-script@v7 | ||
if: github.event_name == 'pull_request' | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jef-n I don't think this will work for pull requests made from forks -- the workflow won't have the permission to create comments on the qgis repo. That's why I had to go via the two workflow approach for the ming artifact comments...
If we're adding two windows builds here + 1 from #57414, can we at least drop the existing mingw64 and msys2 workflows? I think 5 separate windows builds is tending slightly toward overkill 🤣 |
😆 I agree I also think the user communication should be quite clear in what should be tested. I.e. the build that is becoming the stable artifact (at the moment qt5) should be most prominent and everything else can be in small print/collapsed etc. Ideally everything in a single comment to not clutter the communication in the PR's with too many comments. |
I agree. And do we really need even 3, it's gonna overload the CI pipeline for basically building the same code with the same compiler. Can we not have qt5 with osgeo4w and vcpkg for qt6 ? |
+1 |
why do we need vcpkg? |
I am not expert with vcpkg but IMHO I see a lot of advantages:
There is a more thorough explanation on why vcpkg on the related QEP. |