Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pull request milestone when it is merged #57421

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented May 14, 2024

Why?

  1. When a PR is created, a milestone is attached to it. That milestone is then added in the issue report generated in the docs repo, to indicate the version.
  2. That version information is reused in the docs repo to assign appropriate version label and milestone to the issue. So we know in which docs a fix should go.
  3. Issue is that, currently, a PR opened during dev cycle A but merged in cycle B still kept the A milestone attached hence old version assigned. Meaning that in the docs repo, we end up with wrong information assigned to the issues that are created, and potentially could backport some fixes to a docs version they do not belong to.

What I'm not sure of with this fix is whether the milestone will be updated before the issue report is created in docs repo. Hence based on https://docs.github.com/en/actions/using-workflows/reusing-workflows, I have that other branch I can't really test (any GH actions guru?) that, from my understanding, should circumvent that.

@github-actions github-actions bot added this to the 3.38.0 milestone May 14, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 5982c41)

Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 29, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant