Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display more columns in the "Export Project to Dxf" dialog (take 2 ) #57401

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented May 12, 2024

This PR is an alternative approach to #57155: instead of a QgsLayerTreeView it uses a QTreeView for automatically displaying all the columns in the dialog. This seems to be the actual widget type used in the other dialogs that display layer tree along with other columns (see #57155 (comment)).
It reverts #56082 that looks more like a hack to me, as we need to adjust width bounds whenever number of columns changes.

dxfColumnsSize.mp4

The bad news: it doesn't work. I can get the dialog with columns visible and I could export a project. But some interactions with the dialog (e.g. double-click in a cell, resizing dialog not the columns) lead to a freeze then a crash (of my whole computer). An issue with the Q_ASSERT below but this is a too high level for my c++ understanding.

QgsVectorLayer *FieldSelectorDelegate::indexToLayer( const QAbstractItemModel *model, const QModelIndex &index ) const
{
const QgsLayerTreeProxyModel *proxy = qobject_cast< const QgsLayerTreeProxyModel *>( model );
Q_ASSERT( proxy );

These were somehow of a hack and complicates the widget handling with columns addition
Also clean up ui file, add spacing and set convenient behavior and default width for columns
@github-actions github-actions bot added this to the 3.38.0 milestone May 12, 2024
@DelazJ DelazJ changed the title Display more columns in the "Export Project to Dxf" dialog (take ) Display more columns in the "Export Project to Dxf" dialog (take 2 ) May 12, 2024
@DelazJ DelazJ added GUI/UX Related to QGIS application GUI or User Experience DXF/DWG Relating to DXF or DWG importing/exporting Bug Either a bug report, or a bug fix. Let's hope for the latter! labels May 12, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 66d3ed9)

@nyalldawson nyalldawson added the Freeze Exempt Feature Freeze exemption granted label May 17, 2024
Copy link

github-actions bot commented Jun 1, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting Freeze Exempt Feature Freeze exemption granted GUI/UX Related to QGIS application GUI or User Experience stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants