[Backport queued_ltr_backports] Fix merge features with hidden fields #57376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t only URL Since QGIS 3.32, when QGIS and QGIS Server loading Project with old HTML-enabled label items, it was automatically into html items. #53192 QGIS Server GetPrint request provides the ability to update label and html items, but for html items, it only accept URL. QGIS Server was not taken into account the html item content mode, so the automotically migrate old HTML-enabled label items into html items can no longer be modifiable. They were only clear if the value provided is not an URL. Funded by 3Liz
…ackports [Backport queued_ltr_backports] [Bugfix] Server GetPrint set HTML content of QgsLayoutItemHtml and not only URL
Before this modification, user was added to realm before storing credentials, so we failed at retrieving from cache when no username was provided. Fixes #56535
GHA has recently switched the macos-latest alias to be macos-14 which is OSX Arm64. macos-13 is x64 architecture instead
Qt3D overlay is drawn using imgui which is imperative, so Qt3D needs to cache events until they are needed for the actual rendering of the overlay, especially since this happens in a different thread. When render policy is set to OnDemand though, Qt3D does not cache the entire history of events since the previous update and events can go missing or come out of sequence, which confuses imgui. This patch changes the render policy to Always while the overlay is visible, so it now responds to events. It will also provide more accurate display of performance data in that mode.
The `QgsProject::addLayer` method which add a layer from DOM layer element uses the method `projectFlagsToLayerReadFlags` to get layer read flags from project flags. The generated layer read flags is used into the `QgsMapLayer::readLayerFromXml` method. This method read the extent from XML only if the `QgsMapLayer::FlagReadExtentFromXml` flag is set. If it is not set, the layer extent (provided by the provider) and layer extent from xml are empty. So even if the read extent from xml is set to true for vector layer, the extent will be always provided by the provider if the flag `QgsMapLayer::FlagReadExtentFromXml` is not provided to `QgsMapLayer::readLayerFromXml` method. To fix it, we proposed to update `QgsProject::projectFlagsToLayerReadFlags` method to provide `QgsMapLayer::FlagReadExtentFromXml` from project flags. Funded by Tenergie
new item: navstatus
Update RMC sentence for NMEA v4.1
…ports [Backport queued_ltr_backports] QgsProject: The flag to read extent from xml was set too late
Instead of ignoring always hidden fields, use field default value or value from one of merged features. Fixes #28253 Co-authored-by: Joonalai <joona.laine@cofactor.fi>
nyalldawson
force-pushed
the
queued_ltr_backports
branch
2 times, most recently
from
f1067f1
to
ed7533d
Compare
|
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
github-actions
bot
added
the
stale
|
Not stale, needs still review @nyalldawson @elpaso |
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #56825
Authored by: @vaahtokarkki