-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Qt6 builds based on vcpkg #57414
base: master
Are you sure you want to change the base?
Conversation
Nice work @m-kuhn ! Could you adapt the logic from https://github.com/qgis/QGIS/blob/master/.github/workflows/mingw64.yml#L97 to tag the artifact with the corresponding pr number and sha, and then update https://github.com/qgis/QGIS/blob/master/.github/workflows/build_artifact_comment.yml#L5 so that we get a PR comment with a direct link to download the qt6 artifacts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
It looks good! (Though I'm not a Vcpkg expert)
After discussing it in Grenoble, it's really great to see all this work come to maturity and take the form of a PR! |
I tried but it doesn't seem to be triggered. Is it possible that this only runs once it's in master? Do you have any recommendation on developing such an action script and testing changes efficiently? |
The changes to the build artifact comment workflows must be applied in master before it'll work on a pull request. I'd say do what everyone has to do in this situation and just directly modify the workflow on master 😂 |
😱 I have close to 0 confidence in my js skills, so I'll have to do multiple commits to debug 😱 |
|
or push your branch to your own fork but as the master branch ? |
That only helps half way jef-n#19 - the second workflow is not required then. |
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
Description
Refs qgis/QGIS-Enhancement-Proposals#292
This adds windows builds with Qt6, based on vcpkg dependencies.
The features
WITH_BINDINGS
,WITH_3D
andWITH_GUI
are supported and appropriately enable or disable building the required dependencies. Feature dependencies for server, opencl and quick are prepared but not yet wired.Python support is consumed from https://github.com/open-vcpkg/python-registry/ . This is currently focused on shipping python dependencies that contain native code (dll's). Other dependencies can be installed using pip.
It is currently based on Qt 6.7.0.
Various Qt6 compatibility patches have been ported from #56980 and #56841 (QGIS code is now wchar / unicode aware for Qt6, external dependencies are patched to make them build).
TODO:
bin
More ideas:
X_VCPKG_APPLOCAL_DEPS_INSTALL
instead of blindly copying all .dll's, probably in a followup PR