Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DXF Export (app and processing) documentation #8995

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

gacarrillor
Copy link
Member

@gacarrillor gacarrillor commented Apr 2, 2024

@gacarrillor
Copy link
Member Author

@DelazJ, should these icons reflect the default value for each checkbox?

image

I'm asking because if that's the case, I could update them in this PR.

@gacarrillor gacarrillor changed the title Fix #8961 (Add option 'Use only selected features' to DXF export) Update DXF Export (app and processing) documentation Apr 2, 2024
Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these icons reflect the default value for each checkbox?

@gacarrillor Yes, that was the idea. Thanks for fixing.

Do you also plan to clarify what the layer title refers to?

@@ -680,6 +680,7 @@ guidelines:
LayoutItem ``layoutitem``
Color ``color``
Scale ``scale``
Map theme ``map theme``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary. I see the list has unnecessarily grown... The initial intent was to list available specific widgets and assign to parameters the one they used in the GUI.
Specifically, map themes are text string in a combobox, so I would just go with enumeration but I see there is already a "maptheme" type.
I will try to revisit this in upcoming weeks. Any idea/feedback for clarification will be more than welcome in the meantime... (I must admit I'm myself confused on how these are used throughout the docs)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, map extent and map theme have already their own processing widgets, so IMHO when users/devs look at the docs (e.g., to replicate the widget in a custom processing algorithm), it'd be great if we could point them at the more specific widget, i.e., instead of pointing them to an enumeration, we could let them know they can/should use the more specific map theme widget.

@gacarrillor
Copy link
Member Author

should these icons reflect the default value for each checkbox?

@gacarrillor Yes, that was the idea. Thanks for fixing.

I'll do that in this PR.

Do you also plan to clarify what the layer title refers to?

Sure! I started by asking for some agreement here and now that the scenario is clearer we could explain a little bit both the title provenance.

@DelazJ
Copy link
Collaborator

DelazJ commented Apr 15, 2024

Yes! sorry for the silence, holidays... and I noticed that things were sorted out in the meantime.

@gacarrillor
Copy link
Member Author

should these icons reflect the default value for each checkbox?

@gacarrillor Yes, that was the idea. Thanks for fixing.

Do you also plan to clarify what the layer title refers to?

Done!
Note this is not the only PR for which I'll need to touch DXF export docs. If that's fine for you, we could merge this one to do incremental changes via PRs. Otherwise, all upcoming changes (e.g., this, this and this ) would need to land in this PR.

Yes! sorry for the silence, holidays... and I noticed that things were sorted out in the meantime.

No worries, that was my first guess! :)

Co-authored-by: Harrissou Sant-anna <delazj@gmail.com>
@DelazJ DelazJ merged commit 93ef0bd into qgis:master Apr 17, 2024
2 of 3 checks passed
@gacarrillor gacarrillor deleted the fix_8961_dxf_selected_features branch April 17, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option 'Use only selected features' to DXF export (Request in QGIS)
2 participants