Attention sparse embeddings #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joein
reviewed
May 15, 2024
| "History is merely a list of surprises... It can only prepare us to be surprised yet again.", | ||
| ])) | ||
|
|
||
| for result in output: |
There was a problem hiding this comment.
I bet this test could be better :D
There was a problem hiding this comment.
I am open to suggestions
There was a problem hiding this comment.
I would check some types / shapes / values (e.g. that query values are [1, 1, 1, 1]), etc.
By the way, should not we initialize it as SparseTextEmbedding(model_name="Qdrant/bm42-all-minilm-l6-v2-attentions") ?
If we want to initialize it as SparseTextEmbedding, then we also need to overload methods like query_embed in it.
Other than this, the PR looks ok
There was a problem hiding this comment.
If we want to initialize it as SparseTextEmbedding, then we also need to overload methods like query_embed in it.
yeah, this is right
generall
force-pushed
the
attention-sparse-embeddings
branch
from
ee7a780
to
ad80e59
Compare
joein
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro new sparse model based on attention weights. Consider it as an extension of bm25 for short documents.