Add geo types support #30
Conversation
|
|
||
| // add macro for creating circles | ||
|
|
||
| #[derive(Eq, PartialEq, Clone, Copy, Debug, Hash)] |
There was a problem hiding this comment.
Do you really need all these traits?
There was a problem hiding this comment.
I was focused on implementation that would look like other interfaces from geo types.
So it`s why i have this traits.
There was a problem hiding this comment.
I don't completely understand, could you please explain it a bit more clearly?
There was a problem hiding this comment.
For implementation geometric types in PostgreSQL I use geo_types module in Rust.
Mostly geometric types are already realised in module, so while making Circle interface i referred to implementation of ready geometric types interfaces in geo_types module.
|
Btw. Looks great! Hope to see the final version soon! |
|
Today will update on using exceptions that changed after main branch merge |
| @@ -569,6 +648,70 @@ fn postgres_bytes_to_py( | |||
| Ok(py.None().to_object(py)) | |||
| } | |||
| } | |||
| // ---------- Geo Types ---------- | |||
|
Add tests, please |
Added geo types support from PostgreSQL and geo_types module in Rust.
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: