Fix mono_t2.m not returning offset value and not using it in plot #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to limited time on my side, I cannot do the extended tests (saving/loading of models, etc.) since we do not need this functionality at the moment. I have verified that this works as expected for doing the fits, though.
For this reason, I marked the PR as a draft.
Purpose
Describe the problem or feature in addition to a link to the issues.
Fixes #489 upstream such that offset fit result is propagated and the plot equation & fit is consistent with its options.
Approach
How does this change address the problem?
Write offset to returned fit results struct if model fits with offset.
Maybe consider returning offset = 0 if no offset was used to maintain structure of output.
equation() was changed to include the offset in the returned equation.
plot() was changed to print offset in title if it's present.
Open Questions and Pre-Merge TODOs
Use github checklists. When solved, check the box and explain the answer.
Review that changed source files/lines are related to the pull request/issue
If any files/commits were accidentally included, cherry-pick them into another branch.
Review that changed source files/lines were not accidentally deleted
Fix appropriately if so.
Test new features or bug fix
If not implemented/resolved adequately, solve it or inform the developer by requesting changes in your review.
Preferably, set breakpoints in the locations that the code was changed and follow allong line by line to see if the code behaves as intended.
Manual GUI tests (general)
Specifications