-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mb/qmt ismrm #468
base: master
Are you sure you want to change the base?
Mb/qmt ismrm #468
Conversation
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
- Coverage 47.40% 46.57% -0.83%
==========================================
Files 260 260
Lines 8647 8655 +8
==========================================
- Hits 4099 4031 -68
- Misses 4548 4624 +76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathieuboudreau in this commit there were some commented lines in the function qmt_spgr/Sim_Single_Voxel_Curve that were preventing to successfully run the Sim_Sensitivity_Analysis
. I fixed that issue in this commit.
Also, I locally tested the SimDemo_bSSFP_Test
, SimDemo_SIRFSE_Test
, and SimDemo_SPGR_Test
and they all failed due to wrong filename of SimDemo files. This was fixed in. This was fixed in commit.
Purpose
Describe the problem or feature in addition to a link to the issues.
Approach
How does this change address the problem?
Open Questions and Pre-Merge TODOs
Use github checklists. When solved, check the box and explain the answer.
Review that changed source files/lines are related to the pull request/issue
If any files/commits were accidentally included, cherry-pick them into another branch.
Review that changed source files/lines were not accidentally deleted
Fix appropriately if so.
Test new features or bug fix
If not implemented/resolved adequately, solve it or inform the developer by requesting changes in your review.
Preferably, set breakpoints in the locations that the code was changed and follow allong line by line to see if the code behaves as intended.
Manual GUI tests (general)
Specifications