Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mb/qmt ismrm #468

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Mb/qmt ismrm #468

wants to merge 20 commits into from

Conversation

mathieuboudreau
Copy link
Member

Purpose

Describe the problem or feature in addition to a link to the issues.

Approach

How does this change address the problem?

Open Questions and Pre-Merge TODOs

  • Use github checklists. When solved, check the box and explain the answer.

  • Review that changed source files/lines are related to the pull request/issue
    If any files/commits were accidentally included, cherry-pick them into another branch.

  • Review that changed source files/lines were not accidentally deleted
    Fix appropriately if so.

  • Test new features or bug fix
    If not implemented/resolved adequately, solve it or inform the developer by requesting changes in your review.
    Preferably, set breakpoints in the locations that the code was changed and follow allong line by line to see if the code behaves as intended.

Manual GUI tests (general)
  • Does the qMRLab GUI open?
  • Can you change models?
  • Can you load a data folder for a model?
  • Can you view data?
  • Can you zoom in the image?
  • Can you pan out of the image?
  • Can you view the histogram of the data?
  • Can you change the color map?
  • Can you fit dataset (Fit data)?
  • Can you save/load the results?
  • Can you open the options panel?
  • Can you change option parameters?
  • Can you save/load option paramters?
  • Can you select a voxel?
  • Can you fit the data of that voxel ("View data fit")?
  • Can you simulate and fit a voxel ("Single Voxel Curve")?
  • Can you run a Sensitivity Analysis?
  • Can you simulate a Multi Voxel Distribution?
Specifications
  • Version:
  • Platform:
  • Subsystem:

@mathieuboudreau mathieuboudreau marked this pull request as draft May 9, 2022 12:48
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #468 (036d5d3) into master (8b8fb39) will decrease coverage by 0.82%.
The diff coverage is n/a.

❗ Current head 036d5d3 differs from pull request most recent head bec946d. Consider uploading reports for the commit bec946d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
- Coverage   47.40%   46.57%   -0.83%     
==========================================
  Files         260      260              
  Lines        8647     8655       +8     
==========================================
- Hits         4099     4031      -68     
- Misses       4548     4624      +76     
Flag Coverage Δ
matlab 46.57% <ø> (-0.05%) ⬇️
octave ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Common/pulse/ViewPulse.m 0.00% <ø> (ø)
src/Common/qMRgenBatch.m 87.41% <ø> (-3.24%) ⬇️
src/Common/tools/GenerateButtons.m 0.00% <ø> (ø)
src/Models/Magnetization_transfer/qmt_bssfp.m 90.62% <ø> (ø)
src/Models/Magnetization_transfer/qmt_sirfse.m 59.50% <ø> (-4.14%) ⬇️
src/Models/Magnetization_transfer/qmt_spgr.m 64.23% <ø> (-0.84%) ⬇️
...ls_Functions/SPGRfun/functions/SPGR_PlotSimCurve.m 77.77% <ø> (-10.23%) ⬇️
src/Models_Functions/SPGRfun/functions/SPGR_sim.m 0.00% <ø> (ø)
src/Common/tools/versionChecker.m 0.00% <0.00%> (-62.17%) ⬇️
src/Common/qMRinfo.m 42.85% <0.00%> (-42.86%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b8fb39...bec946d. Read the comment docs.

@jvelazquez-reyes jvelazquez-reyes marked this pull request as ready for review July 11, 2022 23:10
@jvelazquez-reyes jvelazquez-reyes marked this pull request as draft July 11, 2022 23:13
Copy link
Collaborator

@jvelazquez-reyes jvelazquez-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathieuboudreau in this commit there were some commented lines in the function qmt_spgr/Sim_Single_Voxel_Curve that were preventing to successfully run the Sim_Sensitivity_Analysis. I fixed that issue in this commit.

Also, I locally tested the SimDemo_bSSFP_Test, SimDemo_SIRFSE_Test, and SimDemo_SPGR_Test and they all failed due to wrong filename of SimDemo files. This was fixed in. This was fixed in commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants