-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix event signature #250
base: main
Are you sure you want to change the base?
fix event signature #250
Conversation
"#{name}(#{types.join(",")})" | ||
end | ||
|
||
def type(input) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add basic docs to the method? 🙏🏼
if input["type"] == "tuple" | ||
"(#{input["components"].map {|c| type(c) }.join(",")})" | ||
elsif input["type"] == "enum" | ||
"uint8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you provide a test case for tuple
and enum
so I can make sure not to break it in future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore the failing spec, it does not work on CI due to permissions.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 99.70% 99.44% -0.27%
==========================================
Files 77 77
Lines 4477 4483 +6
==========================================
- Hits 4464 4458 -6
- Misses 13 25 +12 ☔ View full report in Codecov by Sentry. |
No description provided.