Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add click() to baseWrapper #601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cmhulbert
Copy link

UIAwrapper claims to have click() functionality, but it only has
click_input functionality. This adds click functionality similar to that
in uia_controls, by using Invoke pattern.

UIAwrapper claims to have click() functionality, but it only has
click_input functionality. This adds click functionality similar to that
in uia_controls, by using Invoke pattern.
@codecov
Copy link

codecov bot commented Nov 10, 2018

Codecov Report

Merging #601 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
- Coverage   95.69%   95.62%   -0.08%     
==========================================
  Files          49       49              
  Lines       20157    20160       +3     
==========================================
- Hits        19290    19278      -12     
- Misses        867      882      +15

Copy link
Contributor

@vasily-v-ryabov vasily-v-ryabov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution. But this is not the right place for click() method. BaseWrapper is a base class for both backends including "win32". And it's kind of abstract class.

More proper place is UIAWrapper where you can add alias click = invoke and remove it from uia_controls.ButtonWrapper.

The initial idea for this alias for ButtonWrapper only is that InvokePattern may have different meaning. But it seems many buttons have custom control type, but implemnt InvokePattern anyway.

So I agree to move it from ButtonWrapper to UIAWrapper. Just make it properly please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants