New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add window_specification
module and move WindowSpecification
definition to that
#1326
base: atspi
Are you sure you want to change the base?
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## atspi #1326 +/- ##
==========================================
- Coverage 94.15% 87.86% -6.30%
==========================================
Files 60 61 +1
Lines 23036 23040 +4
==========================================
- Hits 21689 20243 -1446
- Misses 1347 2797 +1450 |
@@ -162,7 +162,7 @@ | |||
|
|||
Current wrapper object is used as a parent while searching in the subtree. | |||
""" | |||
from .base_application import WindowSpecification | |||
from .window_specification import WindowSpecification |
Check notice
Code scanning / CodeQL
Cyclic import Note
pywinauto.window_specification
|
||
from . import controls | ||
from . import findbestmatch | ||
from . import findwindows |
Check notice
Code scanning / CodeQL
Cyclic import Note
pywinauto.findwindows
from . import findbestmatch | ||
from . import findwindows | ||
|
||
from . import backend as backends |
Check notice
Code scanning / CodeQL
Cyclic import Note
The
WindowSpecification
is referred from bothApplication
andDesktop
, but it was defined in thebase_application
module.Thus, the
Desktop
needs to import theWindowSpecification
frombase_application
module. It makes an undesirable dependency.Additionally,
WindowSpecification
is a concrete class, and defining it in a module namedbase_...
feels somewhat out of place.I moved the definition of
WindowSpecification
to a module namedwindow_specification
, similar to howBackEnd
in thebackend
module.