small fix in uia_defines
#1322
Open
small fix in uia_defines
#1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In reality, what is passed to `QueryInterface` is not the "class name" but the "pattern class", so I changed the variable names to be appropriate.
Previously, it was 'MulipleView' instead of 'MultipleView', which is why `IUIAutomationMultipleViewPattern` or `UIA_MultipleViewPatternId` could not be found in `comtypes.gen.UIAutomationClient`.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## atspi #1322 +/- ##
==========================================
- Coverage 94.15% 87.84% -6.31%
==========================================
Files 60 60
Lines 23036 23034 -2
==========================================
- Hits 21689 20235 -1454
- Misses 1347 2799 +1452 |
vasily-v-ryabov
approved these changes
Aug 18, 2023
|
If this PR gets merged, I'm planning to work for refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delint and rename variables within
get_elem_interfaceIn reality, what is passed to
QueryInterfaceis not the "class name" but the "pattern class", so I changed the variable names to be appropriate.fix base name typo
Previously, it was 'MulipleView' instead of 'MultipleView', which is why
IUIAutomationMultipleViewPatternorUIA_MultipleViewPatternIdcould not be found incomtypes.gen.UIAutomationClient.