Implement native backend for WPF applications #1210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented: children(), class_name, name (temporary works like auto_id)
|
Also "1 new alert" is found by LGTM. |
vasily-v-ryabov
requested changes
May 27, 2022
pywinauto/controls/wpf_controls.py
Outdated
| for i in range(1, items_cnt): | ||
| menu = next_level_menu(menu, menu_items[i], items_cnt == i + 1) | ||
| except AttributeError: | ||
| raise IndexError() |
There was a problem hiding this comment.
Any error message? Or maybe better forward it from AttributeError object?
There was a problem hiding this comment.
These lines is copied from the same method from UIA backend (uia_controls.py, line 1129).
Is it need to add error messages to the UIA-related method too?
There was a problem hiding this comment.
It would be nice to do it in both places.
There was a problem hiding this comment.
Done. Note: these exceptions are usually raised when trying to access field of None value, wrong index in a list, etc. I added the variable to store index of the current item in menu path and use this index in the raised exception message.
due to conflict with get_properties in BaseWrapper
eltimen
force-pushed
the
dotnet-injector-backend
branch
from
d2b4d2b
to
7ff48f6
Compare
eltimen
force-pushed
the
dotnet-injector-backend
branch
3 times, most recently
from
2b1749d
to
dba70a8
Compare
eltimen
force-pushed
the
dotnet-injector-backend
branch
from
dba70a8
to
9600950
Compare
eltimen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backend uses .NET DLL injection to find WPF widgets, get their properties and perform actions on them.
TODOs:
ListViewinGridViewmode,DataGrid).type_keys()sporadic unit test failure (self-resolved?)injectedsubmodule