Update base_wrapper.py #1109
Open
Update base_wrapper.py #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## atspi #1109 +/- ##
==========================================
- Coverage 89.28% 89.28% -0.01%
==========================================
Files 58 58
Lines 22190 22190
==========================================
- Hits 19813 19812 -1
- Misses 2377 2378 +1 |
|
It looks like workaround for #676. I'm not willing to merge such hard-coded magic numbers. It may depend on screen resolution and some other factors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added static modifiers have been added in order to correct the unwanted pixels (Transparent and Colored Borders) being captured.