Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix can't download this video 1911 #1913

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix can't download this video 1911 #1913

wants to merge 3 commits into from

Conversation

SarthakNikhal
Copy link

@SarthakNikhal SarthakNikhal commented Apr 20, 2024 •
edited

Fix for #1911

  • This commit moves a tiny part of the stream function so that the part gets involved in exception handling of the http responses. This handles the IncompleteRead Exception which was used only for the response and not the data chunk extracted from the response.
  • This change will also bring some encapsulation of the response and chunk extracting process.

@SarthakNikhal
Copy link
Author

SarthakNikhal commented Apr 25, 2024 •
edited

@RONNCC Let me know if any further work is required following this. I have tested my changes by downloading different types of videos. If you see a flaw. Please me ping me. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SarthakNikhal