Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG FIX] fix Unexpected renderer encountered bug. Issue #1899, #1901 #1908

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaykim97
Copy link

@jaykim97 jaykim97 commented Apr 6, 2024

This fix addresses the following raised issues
#1901
#1899

Problem:
Unexpected renderer encountered error when Search results includes "reelShelfRenderer" or "adSlotRenderere"

Implementation:
reelShelfRenderer refers to Youtube Shorts results in Search
adSlotRenderer refers to advertisement Advertisement

In search.py::fetch_and_parse() Added new conditions to skip "reelShelfRenderer" and "adSlotRenderer"

Code Sample:

from pytube import Search
s = Search('YouTube Rewind')
print(len(s.results))

Previous Output(Error):

Unexpected renderer encountered.
Renderer name: dict_keys(['reelShelfRenderer'])
Search term: YouTube Rewind
Please open an issue at https://github.com/pytube/pytube/issues and provide this log output.
Unexpected renderer encountered.
Renderer name: dict_keys(['adSlotRenderer'])
Search term: YouTube Rewind
Please open an issue at https://github.com/pytube/pytube/issues and provide this log output.
Unexpected renderer encountered.
Renderer name: dict_keys(['reelShelfRenderer'])
Search term: YouTube Rewind
Please open an issue at https://github.com/pytube/pytube/issues and provide this log output.
17

NewOutput:

17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant