Fixed the Description bug #1863
Conversation
There was a problem hiding this comment.
Why get rid of getting data from vid_info altogether? It should at least be used as a fallback.
Also, not really fond of doing requests inside a property getter. It should be a separate function/method, and I also think it should be called as a fallback if nothing is found in vid_info.
pytube/__main__.py
Outdated
| ind1 = page_detail.index(''.join(match1)) + 19 | ||
| ind2 = page_detail.index(''.join(match2)) - 3 |
There was a problem hiding this comment.
What are these magic numbers?
There was a problem hiding this comment.
Initially, I considered creating another request and then retrieving the description from the HTML. However, I discovered that "self.watch_html" also contains the description between "Shortdescription" and "iscrawlable." Therefore, I utilized a regex to find their indexes and return anything in between them, which constitutes the description. The addition and subtraction of 3 is for removing the colon and double quotes to get the text only.
The latest commit "Removed Internal request for Description - 2" consist of all the changes i mentioned
|
Using vid_info wouldn't be useful as it doesn't contain relevant information regarding the description. |
|
Any Update?? |
|
Waiting for it to get merged then. |
Since the video info was not returning anything related to description, I created another http get request to fetch the description using regex.