Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix posttroll-based notifier for move it server #195

Merged
merged 2 commits into from
May 27, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Mar 1, 2024

This PR fixes the mess created with the watchdog refactoring to the posttroll-based notifier.

@mraspaud mraspaud added the bug label Mar 1, 2024
@mraspaud mraspaud requested a review from TAlonglong March 1, 2024 13:54
@mraspaud mraspaud self-assigned this Mar 1, 2024
@mraspaud mraspaud requested a review from pnuu as a code owner March 1, 2024 13:54
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 70.37037% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 91.28%. Comparing base (a52ee84) to head (b67812c).
Report is 12 commits behind head on main.

Files Patch % Lines
trollmoves/server.py 60.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   91.12%   91.28%   +0.15%     
==========================================
  Files          26       26              
  Lines        5421     5417       -4     
==========================================
+ Hits         4940     4945       +5     
+ Misses        481      472       -9     
Flag Coverage Δ
unittests 91.28% <70.37%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

trollmoves/server.py Outdated Show resolved Hide resolved
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnuu pnuu merged commit 00f0750 into pytroll:main May 27, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move it server fails to start when config uses listen instead of origin
2 participants