Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels with numpy 2 #164

Merged
merged 1 commit into from Feb 14, 2024
Merged

Build wheels with numpy 2 #164

merged 1 commit into from Feb 14, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 14, 2024

Until numpy 2 is officially out these changes are needed to build a wheel compatible with numpy 1 and numpy 2.

  • Closes #xxxx (remove if there is no corresponding issue, which should only be the case for minor changes)
  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Passes git diff origin/master **/*py | flake8 --diff (remove if you did not edit any Python files)
  • Fully documented (remove if this change should not be visible to users, e.g., if it is an internal clean-up, or if this is part of a larger project that will be documented later)

@djhoese djhoese added enhancement dependencies Pull requests that update a dependency file labels Feb 14, 2024
@djhoese djhoese self-assigned this Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97231c0) 91.63% compared to head (2d126fc) 91.63%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files          12       12           
  Lines        4043     4043           
=======================================
  Hits         3705     3705           
  Misses        338      338           
Flag Coverage Δ
unittests 91.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 91.867%. remained the same
when pulling 2d126fc on djhoese:feat-wheel-np2
into a57ac0b on pytroll:main.

@djhoese djhoese merged commit 2e75db7 into pytroll:main Feb 14, 2024
26 checks passed
@djhoese djhoese deleted the feat-wheel-np2 branch February 14, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants