New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Missing Labels in FER2013 Dataset #8118 #8368
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8368
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit e0a702d with merge base 5181a85 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @NSalberg! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
"train": ("icml_face_data.csv", "b114b9e04e6949e5fe8b6a98b3892b1d"), | ||
"test": ("icml_face_data.csv", "b114b9e04e6949e5fe8b6a98b3892b1d"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @NSalberg .
The feature request looks reasonable, however I think we should avoid forcing the existence of icml_face_data.csv
because that will potentially break existing users who only have downloaded train.csv
and test.csv
.
Perhaps we should instead check the existence of icml_face_data.csv
and use it if it exists, and otherwise fall back to train.csv
and test.csv
?
In the current implementation, labels are not provided for test split.
The FER2013 dataset provides labels for both training and testing in the icml_face_data.csv file.
This pull request reads the data from the icml_face_data.csv instead, providing labels for both the train and test splits.