Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UFMT on test_decomp.py, test_expanded_weights.py and some files #125117

Closed
wants to merge 3 commits into from

Conversation

shink
Copy link
Contributor

@shink shink commented Apr 28, 2024

Part of: #123062

Ran lintrunner on:

  • test/test_decomp.py
  • test/test_deploy.py
  • test/test_determination.py
  • test/test_dlpack.py
  • test/test_dynamic_shapes.py
  • test/test_expanded_weights.py

Detail:

$ lintrunner -a --take UFMT --all-files
ok No lint issues.
Successfully applied all patches.

Copy link

pytorch-bot bot commented Apr 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125117

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 02d7d8b with merge base 1dd42e4 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 28, 2024
@cpuhrsch cpuhrsch requested a review from jansel April 30, 2024 19:42
@cpuhrsch cpuhrsch added module: lint Issues related to our Python/C++ lint rules (run by Travis) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 30, 2024
Copy link
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but seems like there are merge conflicts that need to be resolved.

@shink
Copy link
Contributor Author

shink commented May 6, 2024

@jansel all conflicts are resolved, please take a look, thanks!

@jansel
Copy link
Contributor

jansel commented May 6, 2024

@pytorchbot merge

Copy link

pytorch-bot bot commented May 6, 2024

This PR needs to be approved by an authorized maintainer before merge.

@jansel
Copy link
Contributor

jansel commented May 6, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 6, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@shink
Copy link
Contributor Author

shink commented May 6, 2024

fixed:

--- a/test/test_dynamic_shapes.py
+++ b/test/test_dynamic_shapes.py
@@ -838,8 +838,8 @@ class f(torch.nn.Module):
         native_dropout = torch.ops.aten.native_dropout.default(new_empty, 0.5, True);  new_empty = None
         getitem: "f32[s0 + s2, 2*s1]" = native_dropout[0]
         getitem_1: "b8[s0 + s2, 2*s1]" = native_dropout[1];  native_dropout = None
-        return (getitem, getitem_1)""",
-        )  # noqa: B950
+        return (getitem, getitem_1)""",  # noqa: B950
+        )

@jansel
Copy link
Contributor

jansel commented May 6, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: lint Issues related to our Python/C++ lint rules (run by Travis) open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants