Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Add extra cuda_to_hip_mappings.py #125108

Closed
wants to merge 2 commits into from
Closed

[ROCm] Add extra cuda_to_hip_mappings.py #125108

wants to merge 2 commits into from

Conversation

amoskvic
Copy link
Contributor

@amoskvic amoskvic commented Apr 27, 2024 •
edited by pytorch-bot bot

Adding extra mappings discovered when hipifying the backward CUDA kernel of the Mamba model (https://github.com/state-spaces/mamba/).

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

@amoskvic
Add extra cuda_to_hip_mappings.py
5014add 
Adding extra mappings discovered when hipifying the backward CUDA kernel for Mamba (https://github.com/state-spaces/mamba/)
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 27, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125108

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b81fa0f with merge base b4a0082 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Skylion007 Skylion007 added the module: rocm AMD GPU support for Pytorch label Apr 27, 2024
jeffdaily
jeffdaily approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@jeffdaily jeffdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint, otherwise LGTM.

@jeffdaily jeffdaily changed the title Add extra cuda_to_hip_mappings.py [ROCm] Add extra cuda_to_hip_mappings.py May 1, 2024
@jeffdaily
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 1, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@jeffdaily jeffdaily added the topic: not user facing topic category label May 1, 2024
@jeffdaily
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

smalltalkman pushed a commit to smalltalkman/pytorch that referenced this pull request May 1, 2024
@amoskvic @pytorchmergebot
[ROCm] Add extra cuda_to_hip_mappings.py (pytorch#125108)
bf6acf9 
Adding extra mappings discovered when hipifying the backward CUDA kernel of the Mamba model (https://github.com/state-spaces/mamba/).

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
Pull Request resolved: pytorch#125108
Approved by: https://github.com/Skylion007, https://github.com/jeffdaily
@jeffdaily
Copy link
Collaborator

pytorchbot merge didn't close this automatically. Closing manually.

@jeffdaily jeffdaily closed this May 1, 2024
@amoskvic
Copy link
Contributor Author

amoskvic commented May 2, 2024

@jeffdaily thanks for fixing the trailing whitespace issue!

petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@amoskvic @petrex
[ROCm] Add extra cuda_to_hip_mappings.py (pytorch#125108)
ccd23b5 
Adding extra mappings discovered when hipifying the backward CUDA kernel of the Mamba model (https://github.com/state-spaces/mamba/).

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
Pull Request resolved: pytorch#125108
Approved by: https://github.com/Skylion007, https://github.com/jeffdaily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

Assignees
No one assigned
Labels
ciflow/rocm ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amoskvic @jeffdaily @pytorchmergebot @Skylion007 @pytorchbot