New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: nn.Parameter
return type identified as Tensor
instead of nn.Parameter
#125106
Fix: nn.Parameter
return type identified as Tensor
instead of nn.Parameter
#125106
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125106
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d31517c with merge base 8246f42 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot label "module: typing" |
nn.Parameter
return type identified as Tensor
instead of nn.Paramter
nn.Parameter
return type identified as Tensor
instead of nn.Parameter
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@ezyang There is no release note label for type hint changes, which one should I use? nn? |
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot label "release notes: python_frontend" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't effect runtime, so I'm happy with doing it even if it is only a partial fix!
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
….Parameter` (pytorch#125106) Fixes pytorch#125105 Pull Request resolved: pytorch#125106 Approved by: https://github.com/ezyang, https://github.com/albanD
….Parameter` (#125106) Fixes #125105 Pull Request resolved: #125106 Approved by: https://github.com/ezyang, https://github.com/albanD
Fixes #125105
cc @ezyang @malfet @xuzhao9 @gramster @albanD