Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE]: Apply RUF025 perf fixups #125104

Closed
wants to merge 1 commit into from
Closed

[BE]: Apply RUF025 perf fixups #125104

wants to merge 1 commit into from

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Apr 27, 2024 •
edited by pytorch-bot bot

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 27, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125104

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8311dd7 with merge base 8246f42 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang
Copy link
Contributor

ezyang commented Apr 28, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 28, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@Skylion007 Skylion007 added the topic: not user facing topic category label Apr 28, 2024
@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

carmocca pushed a commit to carmocca/pytorch that referenced this pull request Apr 29, 2024
@Skylion007 @carmocca
[BE]: Apply RUF025 perf fixups (pytorch#125104)
084c8a2 
Uses `dict.fromkeys()` for more efficient dict construction. Automatically generated by RUF025 (prev).

Pull Request resolved: pytorch#125104
Approved by: https://github.com/ezyang
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
@Skylion007 @andoorve
[BE]: Apply RUF025 perf fixups (pytorch#125104)
517b288 
Uses `dict.fromkeys()` for more efficient dict construction. Automatically generated by RUF025 (prev).

Pull Request resolved: pytorch#125104
Approved by: https://github.com/ezyang
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@Skylion007 @petrex
[BE]: Apply RUF025 perf fixups (#125104)
00172bb 
Uses `dict.fromkeys()` for more efficient dict construction. Automatically generated by RUF025 (prev).

Pull Request resolved: #125104
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@malfet malfet Awaiting requested review from malfet

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor oncall: pt2 open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Skylion007 @ezyang @pytorchmergebot @pytorchbot