Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pruning]add dropout to list of supported activation functions #125101

Closed
wants to merge 1 commit into from

Conversation

UsingtcNower
Copy link

@UsingtcNower UsingtcNower commented Apr 27, 2024

Summary:
Add nn.Dropout and F.dropout to list of suppported activation functions

Test Plan:

python test/test_ao_sparsity.py -- TestBaseSparsifier

cc @kit1980 @andrewor14 @jcaip Could you please help to review this tiny change?

Copy link

pytorch-bot bot commented Apr 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125101

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 238ab8d with merge base d4a1b3e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

linux-foundation-easycla bot commented Apr 27, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@jcaip
Copy link
Contributor

jcaip commented Apr 30, 2024

Hey @UsingtcNower thank you for the change :) would you mind making this change in torchao instead? We're looking to maybe move this functionality from core to torchao so I want to start collecting all updates there so the eventual integration is easier.

The corresponding line would be here

@jcaip jcaip self-requested a review April 30, 2024 16:49
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 30, 2024
@UsingtcNower
Copy link
Author

UsingtcNower commented Apr 30, 2024

suppported activation functions

Hi @jcaip thanks very much for your reply :) and thanks for providing the excellent torchao. I hava sync this tiny change to torchao with here, could you please help to review it?

@jcaip
Copy link
Contributor

jcaip commented May 1, 2024

Closing as we're consolidating in torchao see here for context.

@jcaip jcaip closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open source release notes: AO frontend triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants