Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS: Capture triton kernel in ET #124775

Closed
wants to merge 15 commits into from
Closed

OSS: Capture triton kernel in ET #124775

wants to merge 15 commits into from

Conversation

shengfukevin
Copy link
Contributor

@shengfukevin shengfukevin commented Apr 23, 2024 •
edited by pytorch-bot bot

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 23, 2024 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124775

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4996387 with merge base 61e937f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@shengfukevin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@shengfukevin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

briancoutinho
briancoutinho approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@briancoutinho briancoutinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@shengfukevin
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 24, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) are pending/not yet run. The first few are:

  • EasyCLA

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@shengfukevin
Copy link
Contributor Author

/easycla

@shengfukevin
Copy link
Contributor Author

"/easycla"

@shengfukevin
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@shengfukevin
Copy link
Contributor Author

@pytorchbot label "release notes: Execution trace supports triton kernel"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 24, 2024

Didn't find following labels among repository labels: release notes: Execution trace supports triton kernel

@shengfukevin
Copy link
Contributor Author

@pytorchbot label "release notes: profiler"

@pytorch-bot pytorch-bot bot added the release notes: profiler release notes category label Apr 24, 2024
@shengfukevin
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

aaronenyeshi
aaronenyeshi requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wait for Brian's PR to land first. We should make sure tests are in a good state, so we can properly catch an ET regressions when this lands. #124856

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

alat-rights pushed a commit to alat-rights/pytorch that referenced this pull request Apr 26, 2024
@shengfukevin
OSS: Capture triton kernel in ET (pytorch#124775)
f346cf7 
This DIFF is to capture triton kernels in execution trace

Pull Request resolved: pytorch#124775
Approved by: https://github.com/briancoutinho
alat-rights pushed a commit to alat-rights/pytorch that referenced this pull request Apr 26, 2024
@pytorchmergebot
Revert "OSS: Capture triton kernel in ET (pytorch#124775)"
de9e943 
This reverts commit c55309e.

Reverted pytorch#124775 on behalf of https://github.com/jeanschmidt due to need to revert so I can revert pytorch#124592 ([comment](pytorch#124775 (comment)))
@shengfukevin
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@shengfukevin
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

carmocca pushed a commit to carmocca/pytorch that referenced this pull request Apr 29, 2024
@shengfukevin @carmocca
OSS: Capture triton kernel in ET (pytorch#124775)
6767202 
This DIFF is to capture triton kernels in execution trace

Pull Request resolved: pytorch#124775
Approved by: https://github.com/briancoutinho
carmocca pushed a commit to carmocca/pytorch that referenced this pull request Apr 29, 2024
@pytorchmergebot @carmocca
Revert "OSS: Capture triton kernel in ET (pytorch#124775)"
09ef18b 
This reverts commit c55309e.

Reverted pytorch#124775 on behalf of https://github.com/jeanschmidt due to need to revert so I can revert pytorch#124592 ([comment](pytorch#124775 (comment)))
carmocca pushed a commit to carmocca/pytorch that referenced this pull request Apr 29, 2024
@shengfukevin @carmocca
OSS: Capture triton kernel in ET (pytorch#124775)
b1ebd9c 
This DIFF is to capture triton kernels in execution trace

Pull Request resolved: pytorch#124775
Approved by: https://github.com/briancoutinho, https://github.com/aaronenyeshi
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
@shengfukevin @andoorve
OSS: Capture triton kernel in ET (pytorch#124775)
40a6603 
This DIFF is to capture triton kernels in execution trace

Pull Request resolved: pytorch#124775
Approved by: https://github.com/briancoutinho
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
@pytorchmergebot @andoorve
Revert "OSS: Capture triton kernel in ET (pytorch#124775)"
d7816fa 
This reverts commit c55309e.

Reverted pytorch#124775 on behalf of https://github.com/jeanschmidt due to need to revert so I can revert pytorch#124592 ([comment](pytorch#124775 (comment)))
andoorve pushed a commit to andoorve/pytorch that referenced this pull request May 1, 2024
@shengfukevin @andoorve
OSS: Capture triton kernel in ET (pytorch#124775)
34fddf8 
This DIFF is to capture triton kernels in execution trace

Pull Request resolved: pytorch#124775
Approved by: https://github.com/briancoutinho, https://github.com/aaronenyeshi
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
@shengfukevin @petrex
OSS: Capture triton kernel in ET (pytorch#124775)
ecc3f1e 
This DIFF is to capture triton kernels in execution trace

Pull Request resolved: pytorch#124775
Approved by: https://github.com/briancoutinho
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@pytorchmergebot @petrex
Revert "OSS: Capture triton kernel in ET (#124775)"
0380440 
This reverts commit c55309e.

Reverted #124775 on behalf of https://github.com/jeanschmidt due to need to revert so I can revert #124592 ([comment](#124775 (comment)))
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
@shengfukevin @petrex
OSS: Capture triton kernel in ET (#124775)
776d214 
This DIFF is to capture triton kernels in execution trace

Pull Request resolved: #124775
Approved by: https://github.com/briancoutinho, https://github.com/aaronenyeshi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briancoutinho briancoutinho briancoutinho approved these changes

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: profiler release notes category Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shengfukevin @facebook-github-bot @pytorchmergebot @jeanschmidt @briancoutinho @aaronenyeshi