-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched the test cases to use threads instead of processes #115032
Conversation
…e changes to use self.build_mesh instead of device_mesh and also removed the with_comms wrapper
|
I was curious to learn more about the motivation behind changing |
def test_addmm(self): | ||
device_mesh = DeviceMesh(self.device_type, list(range(self.world_size))) | ||
self.build_mesh = DeviceMesh(self.device_type, list(range(self.world_size))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On top of Andrew's question, DeviceMesh
return a device_mesh, maybe you want to call it self.device_mesh or self.mesh?
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
I made some modifications to the test cases, switching from processors to using MultithreadTestCase with
DTensorOpTestBase
. Additionally, I replaceddevice_mesh
withself.build_mesh
and eliminated thewith_comms
wrapper, as per your suggestions in other discussions.Fixes #108744
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @kiukchung @LucasLLC @d4l3k