-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated test cases to use MultithreadTestCase #108749
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108749
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New FailuresAs of commit 586c12d with merge base fae9547 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @zou3519 @rohan-varma @H-Huang Please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! a few comments inlined.
skip_unless_torch_gpu, | ||
with_comms, | ||
) | ||
|
||
|
||
class DistMatrixOpsTest(DTensorTestBase): | ||
class DistMatrixOpsTest(DTensorOpTestBase): | ||
@with_comms | ||
def test_addmm(self): | ||
device_mesh = DeviceMesh(self.device_type, list(range(self.world_size))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also change the device_mesh
init to use self.build_mesh
, thanks!
with_comms, | ||
) | ||
|
||
|
||
class DistTensorOpsTest(DTensorTestBase): | ||
class DistTensorOpsTest(DTensorOpTestBase): | ||
@with_comms | ||
def test_aten_contiguous(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, let's use build_mesh instead.
skip_unless_torch_gpu, | ||
with_comms, | ||
) | ||
|
||
|
||
class DistMathOpsTest(DTensorTestBase): | ||
class DistMathOpsTest(DTensorOpTestBase): | ||
@with_comms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the with_comms
wrapper when switching to OpTestBase, please fix those
skip_unless_torch_gpu, | ||
with_comms, | ||
) | ||
|
||
|
||
class DistMatrixOpsTest(DTensorTestBase): | ||
class DistMatrixOpsTest(DTensorOpTestBase): | ||
@with_comms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, can remove with_comms
with_comms, | ||
) | ||
|
||
|
||
class DistTensorOpsTest(DTensorTestBase): | ||
class DistTensorOpsTest(DTensorOpTestBase): | ||
@with_comms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Fixes #108744