Arm backend: Provide more debug info for numerical diff issues #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
freddan80
commented
May 14, 2024
freddan80
commented
- Save torch reference output
- Print useful debug info
- Print path to debug artifacts
* Save torch reference output * Print useful debug info * Print path to debug artifacts Change-Id: I14a84a4b4bca5bef315685fdf9472051de2e5ddc Signed-off-by: Fredrik Knutsson <fredrik.knutsson@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3596
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f059e47 with merge base 4008600 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
freddan80
added
partner: arm
|
Failing tests not related to this PR. Ready to merge. |
digantdesai
approved these changes
May 21, 2024
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@freddan80 have you seen this? https://pytorch.org/executorch/main/sdk-bundled-io.html Instead of saving the reference output as a ad-hoc file, we provide utility function to make the testing easier. |
|
@digantdesai merged this pull request in bc5ba99. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.