In remove noop pass check for symints #3577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3577
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit c4796fb with merge base a707550 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57225749 |
JacobSzwejbka
approved these changes
May 13, 2024
tarun292
added a commit
that referenced
this pull request
May 21, 2024
Summary: This check will fail if there are SymInt's in the shape, and it's not a valid check to do anyways when there are SymInt's. Reviewed By: JacobSzwejbka Differential Revision: D57225749
tarun292
force-pushed
the
export-D57225749
branch
from
33ffc84
to
a1f06ba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57225749 |
Summary: This check will fail if there are SymInt's in the shape, and it's not a valid check to do anyways when there are SymInt's. Reviewed By: JacobSzwejbka Differential Revision: D57225749
facebook-github-bot
force-pushed
the
export-D57225749
branch
from
a1f06ba
to
c4796fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57225749 |
|
This pull request has been merged in d79ba63. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This check will fail if there are SymInt's in the shape, and it's not a valid check to do anyways when there are SymInt's.
Differential Revision: D57225749