Add cpuInfo support for Loongarch systems #92
Conversation
…ding test output to the configuration file and test file
|
Hi @33749110! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@malfet Can you approve? |
There was a problem hiding this comment.
Why do you need to add it to list of Darwin (MacOS/iOS) architectures? Are there any plans for them being released on Apple platform?
Also, can you please add some link to the processor support you are adding to the PR description? I.e. what ISA does it support (quickly looking thru the wiki suggest that it is an extension of MIPS ISA, isn't it?)
CMakeLists.txt
Outdated
| @@ -52,7 +52,7 @@ ENDMACRO() | |||
|
|
|||
| # -- [ Determine target processor | |||
| SET(CPUINFO_TARGET_PROCESSOR "${CMAKE_SYSTEM_PROCESSOR}") | |||
| IF(IOS OR (CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND CMAKE_OSX_ARCHITECTURES MATCHES "^(x86_64|arm64)$")) | |||
| IF(IOS OR (CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND CMAKE_OSX_ARCHITECTURES MATCHES "^(x86_64|arm64|loongarch64)$")) | |||
There was a problem hiding this comment.
I don't think it's a type of HW Apple has announced yet
| IF(IOS OR (CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND CMAKE_OSX_ARCHITECTURES MATCHES "^(x86_64|arm64|loongarch64)$")) | |
| IF(IOS OR (CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND CMAKE_OSX_ARCHITECTURES MATCHES "^(x86_64|arm64)$")) |
|
1.Sorry, this is a small mistake of mine, we currently have no plans to release on IOS. It's been removed. 2.Related links to the Loongarch Isa are as follows: |
|
Conflicts caused by Cmakefile version issues have been resolved. |
|
Do you have any other questions？ |
|
ping |
What does ping mean? May I ask if there are any problems I need to modify in this submission? If not, can I pass it? Thank you very much. |
In addition to the three submissions, the latest version of Googlebenchmark has added support for loongarch.