Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting and Formatting #2353

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Linting and Formatting #2353

wants to merge 3 commits into from

Conversation

filmor
Copy link
Member

@filmor filmor commented Mar 31, 2024

  • Add formatting and linting for C# files
  • Format and fix lints in Python (test) code

@filmor
Copy link
Member Author

filmor commented Mar 31, 2024

I must have messed something up in the C# code while trying to fix the NonCopyableAnalyzer reports. To be honest, at this point I'm not sure how much this one actually helps, seeing that patterns like return NewReference(...) are wrongly reported.

@lostmsu
Copy link
Member

lostmsu commented Apr 7, 2024

Just doublechecking for C#: this change does the proper thing in regards to our .editorconfig? E.g. all settings default except the one set there?

@lostmsu
Copy link
Member

lostmsu commented Apr 7, 2024

TBH, I am not sure formatting is important unless it is in some way extreme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants