Explicitly compare MaybeType objects by name #2270
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
As observed by @rayfalling, multiple instances of
ReflectedType
values might be created in the cache, leading to crashes during stashing.@rayfalling, could you provide a test-case for this?
Does this close any currently open issues?
#2269
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORS
CHANGELOG