Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly compare MaybeType objects by name #2270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

filmor
Copy link
Member

@filmor filmor commented Oct 18, 2023

What does this implement/fix? Explain your changes.

As observed by @rayfalling, multiple instances of ReflectedType values might be created in the cache, leading to crashes during stashing.

@rayfalling, could you provide a test-case for this?

Does this close any currently open issues?

#2269

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the .NET Foundation CLA
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@rayfalling
Copy link

rayfalling commented Oct 18, 2023

What I meet is a Unity Project with FingerGesture plugin
I will prepare Unity Project test case tomorrow
It's nine o'clock in the evening now, I need to get off work first :)

@rayfalling
Copy link

This is the test-case.
You can open it in Unity 2019.4.38f1
minimalTest.zip

@lostmsu
Copy link
Member

lostmsu commented Nov 7, 2023

Do you know circumstances under which this happens? What is the scenario when we can have two different MaybeType with the same name? Perhaps this is what needs to be prevented instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants