Shorter reporting (i.e. don't highlight entire functions for certain errors) #17203
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t include the body" This reverts commit 10c391b. We cannot do this globally as it breaks a lot of stuff.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pertains to #16746, and is a work in progress. Most likely, I'll work into #17006 instead. But since it's been a while, I wanted to have this here to comment on what I learned.
The goal is to avoid highlighting entire functions as the error for things like missing return statement, forgotten
self, etc. I'm not sure we have an exhaustive list of the errors which do this, but perhaps we can find an approach where the entire function is never highlighted as an error.