Fix handling of typing.Optional in stubgen #17197
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running stubgen on my local repository I noticed a couple of errors occurring notably around the handling of typing.Union / typing.Optional when
--inspect-mode
was being used.I am running Python 3.10.14 on Linux.
I put together a mre:
I put this in
mre.py
then ran:I would get:
calling
get_annotations(arg)
fixed this as the object being passed through was <class 'int'> and not the string versionthis was because
Optional[int]
was becomingtyping.Optional
and nottyping.Optional[int]
I updated handling to pass the[int]
through (this may be incorrect though)