feat: introduce InterfaceChoice.AllWithLoopback #1358
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
bdraco
force-pushed
the
interface_choice_exclude_loopback
branch
from
7032d0e
to
72c649b
Compare
bdraco
force-pushed
the
interface_choice_exclude_loopback
branch
from
d78aaa5
to
1070dc5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1358 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 30 30
Lines 3238 3240 +2
Branches 536 542 +6
=======================================
+ Hits 3230 3232 +2
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. |
…k' into interface_choice_exclude_loopback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better fix would be to check the flags in ifaddr/ifaddr#59
InterfaceChoice.Allnow excludes loopback addresses by default since they do not work on most systems. To keep the original behavior passInterfaceChoice.AllWithLoopbackinstead.fixes #1357