Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Setting the PPM advection problem #157

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

aisclark91
Copy link
Collaborator

@aisclark91 aisclark91 commented Apr 14, 2023

This PR, implements:

  • The PPM mesh reconstruction in the interface of the centered state.
  • The advection PPM numerical scheme.
  • An example on which the PPM numerical scheme operates on.
  • A Test that provides the validity of the numerical scheme.

Two more things remain:

  • To clean simulation.py and inherit as much as possible, and make soft links to the original advection problem folder.

@aisclark91 aisclark91 changed the title [WIP] Setting the PPM advection problem 1 [WIP] Setting the PPM advection problem Apr 14, 2023
@aisclark91
Copy link
Collaborator Author

I decided to clean the previous PR, since it contained many forced pushes. (I don't like the idea of pushing something that probably I shouldn't had). The advection PPM method now converges at second order as follows:

smooth_converge

@aisclark91
Copy link
Collaborator Author

Comparing the PPM vs PLM method, I have decided to compare the smooth problem using both methods, giving the following convergence result:
smooth_converge

@aisclark91 aisclark91 changed the title [WIP] Setting the PPM advection problem Setting the PPM advection problem Apr 16, 2023
@aisclark91 aisclark91 changed the title Setting the PPM advection problem [WIP ]Setting the PPM advection problem Apr 16, 2023
@aisclark91 aisclark91 changed the title [WIP ]Setting the PPM advection problem Setting the PPM advection problem Apr 17, 2023
@aisclark91 aisclark91 changed the title Setting the PPM advection problem [WIP] Setting the PPM advection problem Apr 21, 2023
@aisclark91
Copy link
Collaborator Author

This PR is ready for review. One changed proposed by @simonguichandut was to include the PPM as an option in the advection problem, leaving different folders for different time integration schemes. I want to follow this approach in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants