This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
aio: return session closing coroutine #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazAnyVision
changed the title
RazAnyVision
force-pushed
the
aio-wait-for-session-close
branch
from
dfcf6d2
to
598813c
Compare
RazAnyVision
changed the title
aio.Consul.close() uses aiohttp.ClientSession.close() which returns a coroutine that was never awaited. When this happens, RuntimeWarnings are raised on termination: RuntimeWarning: coroutine 'ClientSession.close' was never awaited self._session.close() RuntimeWarning: Enable tracemalloc to get the object allocation traceback Unclosed client session client_session: <aiohttp.client.ClientSession object at 0x7fee7d894340> Unclosed connector connections: [<a long list of connections>] connector: <aiohttp.connector.TCPConnector object at 0x7fee7d894310> In this change the coroutine will be returned so it could be awaited and by that avoids these warnings.
RazAnyVision
force-pushed
the
aio-wait-for-session-close
branch
from
02d7b08
to
709bda2
Compare
|
@RazAnyVision Interested in coming here ？ |
cablehead
force-pushed
the
master
branch
2 times, most recently
from
636f367
to
a91daae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aio.Consul.close() uses aiohttp.ClientSession.close() which returns a coroutine that was never awaited. When this happens, RuntimeWarnings are raised on termination:
RuntimeWarning: coroutine 'ClientSession.close' was never awaited
self._session.close()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fee7d894340>
Unclosed connector
connections: []
connector: <aiohttp.connector.TCPConnector object at 0x7fee7d894310>
In this change the coroutine will be returned so it could be awaited and by that avoids these warnings.