This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
handle CONSUL_HTTP_ADDR including a http:// or https:// scheme #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/poppyred/python-consul2/blob/master/consul/base.py#L335-L353 |
cablehead
force-pushed
the
master
branch
2 times, most recently
from
636f367
to
a91daae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An environment variable of CONSUL_HTTP_ADDR=https://localhost:8501/ is valid for the Consul CLI. This PR allows the scheme/protocol to be pulled out of this environment variable.