Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

Add new acl system #254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add new acl system #254

wants to merge 3 commits into from

Conversation

Dudesons
Copy link

@Dudesons Dudesons commented May 15, 2019 •
edited

@Dudesons Dudesons mentioned this pull request May 15, 2019
Open
@Dudesons Dudesons force-pushed the new-acl-policies-tokens-roles branch from 95b6bd0 to c67c39e Compare May 17, 2019 11:51
nzlosh added a commit to nzlosh/python-consul that referenced this pull request May 24, 2019
@nzlosh
Merged patch from Dudesons PR python-consul#254
537e6b9
abarbare
abarbare reviewed Dec 23, 2019
View reviewed changes
consul/base.py Outdated Show resolved Hide resolved
@Dudesons
Copy link
Author

@abarbare do you have some other request changes / reviews ?

@abarbare
Copy link

@Dudesons Actually yes, the args_to_payload function doesn't fit my requirements as it will push each parameters as query string parameters. However, the Consul API is waiting those parameters as body parameters so it won't work.

I did a patch on my fork but I'm not 100% satisfied at this time of this solution as it mixes query string and body parameters but it works https://github.com/abarbare/python-consul/pull/1/files

@cablehead cablehead force-pushed the master branch 2 times, most recently from 636f367 to a91daae Compare April 15, 2024 01:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abarbare abarbare abarbare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dudesons @abarbare