This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
Pushing docs towards Python 3 #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzlosh
added a commit
to nzlosh/python-consul
that referenced
this pull request
May 28, 2019
cablehead
force-pushed
the
master
branch
2 times, most recently
from
636f367
to
a91daae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not clear from the docs that there is a difference in the returned value between Python 2 and Python 3 (#177 ), so I made a few changes that would make it clear that on Python 3 return value is actually composed of bytes instead of a string.
I did not bother with specifying that Python 2 returns a string mainly because it is being retired by the end of this year. Feel free to push changes that would make clear the distinction between python 2 and 3 return values.