This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
Added node parameter to data in Catalog register #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done so the API properly passes node_meta data to Consul
|
Not sure why the tests are failing, just added one line ;-) |
|
I'd love to see this fixed and merged, this fixed my issue and let me update |
nzlosh
added a commit
to nzlosh/python-consul
that referenced
this pull request
May 28, 2019
|
No interest in fixing this? I don't believe the checks are failing because of my code additions. |
cablehead
force-pushed
the
master
branch
2 times, most recently
from
636f367
to
a91daae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done so the API properly passes node_meta data to Consul. PR #222 did not fix this issue. Consul appears to want node_meta in the data body not params.
I am not sure about the exact mechanisms behind the consul server. Should we remove the node_meta addition to params and only add it to the data body?