This repository has been archived by the owner on Apr 15, 2024. It is now read-only.
FIX: #226 Allows aiohttp.client.ClientSession.close() to be awaited #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwini-balnaves
changed the title
ashwini-balnaves
force-pushed
the
issue-226
branch
from
ba3f811
to
711d64d
Compare
|
@matusvalo did you have time to have a look at this one? |
|
Can anyone merge this pls? |
Closed
|
@cablehead Looks ok, merge please |
|
Ping @cablehead |
nzlosh
added a commit
to nzlosh/python-consul
that referenced
this pull request
May 28, 2019
|
Any news on this being accepted? |
|
@matusvalo @abn @cablehead Guys! Are you still maintain this package? |
|
I built own package with some PRs and uploaded it to PyPi till not released new version, maybe it would be useful for someone |
|
I this PR abandoned by the authors? we need to merge that guy it's already overdue. I'm happy to help if I can in anyway |
cablehead
force-pushed
the
master
branch
2 times, most recently
from
636f367
to
a91daae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #226. Note that this change requires the client code to await (yield from) the Consul.close method. This is how all the other methods work (get, put, delete, etc).