Skip to content
This repository has been archived by the owner on Apr 15, 2024. It is now read-only.

ClientSession.close is a coroutine #226

Open
nugend opened this issue Aug 13, 2018 · 1 comment · May be fixed by #231
Open

ClientSession.close is a coroutine #226

nugend opened this issue Aug 13, 2018 · 1 comment · May be fixed by #231

Comments

@nugend
Copy link

nugend commented Aug 13, 2018

https://github.com/cablehead/python-consul/blob/4ddec9b57eb5284b58967ce1a9b2422519f88cc2/consul/aio.py#L58

  self._session.close()

Getting this error when my process ends.
@ashwini-balnaves
Copy link

ashwini-balnaves commented Aug 21, 2018 •
edited

I have also encountered this issue. I have opened #231 with my solution.

The tests output from test_aio.py had this warning as well, so I could confirm that my PR resolves the issue.

@ashwini-balnaves ashwini-balnaves linked a pull request Aug 21, 2018 that will close this issue
Open
mosquito added a commit to mosquito/python-consul that referenced this issue Oct 8, 2018
@mosquito
fixes python-consul#226
a7f481e
@mosquito mosquito mentioned this issue Oct 8, 2018
Closed
@GeorgianaElena GeorgianaElena mentioned this issue Jul 3, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: #226 Allows aiohttp.client.ClientSession.close() to be awaited ashwini-balnaves/python-consul
2 participants
@nugend @ashwini-balnaves