Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix target fixture registration post pytest 8.1 #690

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dcendents
Copy link
Contributor

fixes #689

Added a test to replicate the issue.
Simply used the same logic pre pytest 8.1 but ajusted the paratemers to create the FixtureDef with expected values post 8.1

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@dcendents
Copy link
Contributor Author

AFAIK the build is fine, the error is out of my control and the failure cancelled the other threads:

[2024-05-10T16:18:47.078Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 563s.', code='throttled')}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple step scenarios targeting the same fixture doesn't update the fixture
1 participant