Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.13 to the test matrix #682

Merged
merged 2 commits into from Mar 17, 2024
Merged

Add python 3.13 to the test matrix #682

merged 2 commits into from Mar 17, 2024

Conversation

youtux
Copy link
Contributor

@youtux youtux commented Mar 17, 2024

Fixes #682

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @youtux - I've reviewed your changes and they look great!

General suggestions:

  • Verify the value assigned to 'ignore-test-outcome' for Python 3.13-dev to ensure it's correctly set.
  • Consider reviewing the consistency of configuration parameters across all Python versions in the test matrix.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/main.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (3ebd9c7) to head (6170a45).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #682   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          50       50           
  Lines        1828     1828           
  Branches      201      201           
=======================================
  Hits         1743     1743           
  Misses         53       53           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ut only by just their identity.

This fixes an issue with python 3.13 (max recursion depth when running `ScenarioTemplate.__eq__`)
@youtux youtux merged commit b542e8e into master Mar 17, 2024
13 of 15 checks passed
@youtux youtux deleted the add-py3.13 branch March 17, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant